Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: GitOps JupyterBook -> Backstage [part 1] #2683

Merged
merged 1 commit into from
Dec 12, 2022
Merged

docs: GitOps JupyterBook -> Backstage [part 1] #2683

merged 1 commit into from
Dec 12, 2022

Conversation

tumido
Copy link
Member

@tumido tumido commented Dec 12, 2022

Part of: operate-first/service-catalog#196

mkdocs doesn't allow building documentation from the same directory as mkdocs.yaml is located, therefore all the files had to be moved into docs/ folder.

@tumido
Copy link
Member Author

tumido commented Dec 12, 2022

/cc @durandom

@sesheta sesheta requested a review from durandom December 12, 2022 16:22
@sesheta sesheta added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 12, 2022
durandom
durandom reviewed Dec 12, 2022
View reviewed changes
Copy link
Member

@durandom durandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2022
@sesheta
Copy link
Member

sesheta commented Dec 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: durandom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2022
@sesheta sesheta merged commit 11bbd29 into operate-first:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durandom durandom durandom left review comments

Assignees

@durandom durandom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tumido @sesheta @durandom